Ticket #21 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Install button disappears after cancelling on confirm

Reported by: Nicolas Owned by:
Priority: minor Component: Cydia
Keywords: Cc:

Description

To reproduce:

  1. Open Cydia, go to Install, and select a package.
  2. Tap Install button on top.
  3. Confirm window appears. Tap Cancel on top left.
  4. I go back to package details, but Install button is no longer there. I can actually see it for a split second while the confirm window slides down. To get it back, I have to go back to Packages list, and select the package again.

Change History

  Changed 9 months ago by saurik

  • status changed from new to closed
  • resolution set to fixed

Thanks! I figured out what is causing this (calling popViews:, even if the argument is 0, still has side effects such as clearing the button) and why it only happens to Install (it has two level deep of views, so it keeps a count of the number of views to pop and then popViews: that many, whereas if a view needs to be popped in the other views it just calls popViews:1). I have fixed it, and it will be in the Cydia release I'm about to make.

follow-up: ↓ 4   Changed 9 months ago by Nicolas

I can't see the fix in SVN log. (tip: typing "fixes #42" on a commit log makes Trac automatically mark ticket 42 as fixed)

  Changed 9 months ago by Nicolas

But it's indeed fixed in 1.0.2340-31 which I just upgraded to.

in reply to: ↑ 2   Changed 9 months ago by Nicolas

Replying to Nicolas:

I can't see the fix in SVN log. (tip: typing "fixes #42" on a commit log makes Trac automatically mark ticket 42 as fixed)

Oh, Cydia is on a different repo...

  Changed 9 months ago by Nicolas

  • component set to Cydia
Note: See TracTickets for help on using tickets.